lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/14] cgroup: reorganize css init / exit paths
On Mon, Aug 12, 2013 at 10:47:33AM +0800, Li Zefan wrote:
> > + /* each css holds a ref to the cgroup and the parent css */
> > dget(dentry);
> > percpu_ref_get(&css->parent->refcnt);
>
> We called dget() and percpu_ref_get() for each css unconditionally...
>
> > - }
> >
> > - /* hold a ref to the parent's dentry */
> > - dget(parent->dentry);
> > -
> > - /* creation succeeded, notify subsystems */
> > - for_each_root_subsys(root, ss) {
> > - err = online_css(ss, cgrp);
> > + /* creation succeeded, notify subsystems */
> > + err = online_css(css);
> > if (err)
> > goto err_destroy;
>
> but now dget() and percpu_ref_get() may not be called for some css's,
> but the code in failure path is not updated accordingly, which seems
> wrong.

Heh, yeah, brainfart. Will post the updated version.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-08-12 16:01    [W:0.232 / U:0.136 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site