[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 11/44] cpufreq: at32ap: Use generic cpufreq routines
On 10 August 2013 13:53, Hans-Christian Egtvedt <> wrote:
> Around Sat 10 Aug 2013 12:14:07 +0530 or thereabout, Viresh Kumar wrote:
>> Most of the CPUFreq drivers do similar things in .exit() and .verify() routines
>> and .attr. So its better if we have generic routines for them which can be used
>> by cpufreq drivers then.
>> This patch uses these generic routines for this driver.
> Nice, thanks for cleaning up (-:
>> Cc: Hans-Christian Egtvedt <>
>> Signed-off-by: Viresh Kumar <>
> Acked-by: Hans-Christian Egtvedt <>

Thanks for your Ack but I have to NACK it :)

My patch was wrong.. It was based on the assumption that everybody who
had implemented a .target() also implements a frequency table and exposes
it.. And the generic routines I have exposed depend on that frequency table.
And this cpufreq driver doesn't expose that freq table...

And so this patch is dropped :(


 \ /
  Last update: 2013-08-12 08:21    [W:0.254 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site