Messages in this thread Patch in this message | | | Date | Mon, 12 Aug 2013 03:24:22 -0700 | From | tip-bot for Joonsoo Kim <> | Subject | [tip:perf/core] Revert "tools lib lk: Fix for cross build" |
| |
Commit-ID: cecb977e24da1465cdb0ff2d10d22e5891dc3e6c Gitweb: http://git.kernel.org/tip/cecb977e24da1465cdb0ff2d10d22e5891dc3e6c Author: Joonsoo Kim <iamjoonsoo.kim@lge.com> AuthorDate: Tue, 16 Jul 2013 10:03:34 +0900 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Wed, 7 Aug 2013 17:35:41 -0300
Revert "tools lib lk: Fix for cross build"
This reverts commit 079787f209416416383c74ea5d5044be2d586f5e.
Below commit already resolve a cross build problem. I have been noticed this too lately.
commit 3c4797d46c14fa0c7cf733a77bd4b28875078b53 Author: Rabin Vincent <rabin@rab.in> Date: Fri May 17 22:27:44 2013 +0200
tools lib lk: Respect CROSS_COMPILE
Make lk use CROSS_COMPILE, in order to be able to cross compile perf again.
Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <a.p.zijlstra@chello.nl> Link: http://lkml.kernel.org/r/1373936614-22224-1-git-send-email-iamjoonsoo.kim@lge.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/lib/lk/Makefile | 15 --------------- 1 file changed, 15 deletions(-)
diff --git a/tools/lib/lk/Makefile b/tools/lib/lk/Makefile index 280dd82..3dba0a4 100644 --- a/tools/lib/lk/Makefile +++ b/tools/lib/lk/Makefile @@ -3,21 +3,6 @@ include ../../scripts/Makefile.include CC = $(CROSS_COMPILE)gcc AR = $(CROSS_COMPILE)ar -# Makefiles suck: This macro sets a default value of $(2) for the -# variable named by $(1), unless the variable has been set by -# environment or command line. This is necessary for CC and AR -# because make sets default values, so the simpler ?= approach -# won't work as expected. -define allow-override - $(if $(or $(findstring environment,$(origin $(1))),\ - $(findstring command line,$(origin $(1)))),,\ - $(eval $(1) = $(2))) -endef - -# Allow setting CC and AR, or setting CROSS_COMPILE as a prefix. -$(call allow-override,CC,$(CROSS_COMPILE)gcc) -$(call allow-override,AR,$(CROSS_COMPILE)ar) - # guard against environment variables LIB_H= LIB_OBJS=
| |