lkml.org 
[lkml]   [2013]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 17/18] spi: s3c64xx: Always select S3C64XX_PL080 when ARCH_S3C64XX is enabled
Date
Hi Mark,

On Sunday 11 of August 2013 20:11:40 Mark Brown wrote:
> On Sun, Aug 11, 2013 at 07:59:29PM +0200, Tomasz Figa wrote:
> > @@ -366,7 +366,7 @@ config SPI_S3C24XX_FIQ
> >
> > config SPI_S3C64XX
> >
> > tristate "Samsung S3C64XX series type SPI"
> > depends on (ARCH_S3C24XX || ARCH_S3C64XX || ARCH_S5P64X0 ||
> > ARCH_EXYNOS)>
> > - select S3C64XX_DMA if ARCH_S3C64XX && !S3C64XX_PL080
> > + select S3C64XX_PL080 if ARCH_S3C64XX
> >
> > help
> >
> > SPI driver for Samsung S3C64XX and newer SoCs.
>
> Do we need the select here (or should we have other selects for the
> Exynos SoCs)?

The driver would build fine without this symbol selected, but since it
relies on availability of DMA, it doesn't make too much sense to build it
this way. This kind of selects makes kernel configuration more user
friendly IMHO.

Possibly adding appropriate selects (PL330) for s5p* and exynos could make
sense.

Best regards,
Tomasz



\
 
 \ /
  Last update: 2013-08-12 01:21    [W:0.058 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site