lkml.org 
[lkml]   [2013]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 10/13] x86: Move cond resched for copy_{from,to}_user into low level code 64bit
On Sat, Aug 10, 2013 at 09:27:33AM -0700, Linus Torvalds wrote:
> Now, the *debug* logic is entirely different, of course. Maybe the
> problem is that we have mixed up the two so badly, and we have
> "might_sleep()" that implies more of a debug issue than a preemption
> issue, and then people add those because they want the debug coverage
> (and then you *absolutely* want it even for a single-byte user
> mode access). And then because the concept is tied together with
> preemption, we end up doing preemption even for that single-byte
> access despite the fact that it makes no sense what-so-ever.

Sounds like the debug aspect and the preemption point addition need
to be sorf-of split into two different functions/macros and each used
separately.

Something like keep the current might_sleep and have debug_sleep or
similar which does only __might_sleep without the resched...

--
Regards/Gruss,
Boris.

Sent from a fat crate under my desk. Formatting is fine.
--


\
 
 \ /
  Last update: 2013-08-10 21:01    [W:0.050 / U:0.600 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site