Messages in this thread | | | Date | Thu, 1 Aug 2013 15:31:34 +0800 | Subject | Re: [PATCH 1/3] pinctrl: ADI PIN control driver for the GPIO controller on bf54x and bf60x. | From | Sonic Zhang <> |
| |
Hi Linus,
On Tue, Jul 30, 2013 at 12:47 AM, Linus Walleij <linus.walleij@linaro.org> wrote: > On Fri, Jul 26, 2013 at 6:57 AM, Sonic Zhang <sonic.adi@gmail.com> wrote: > >> Could you please comment on this patch set? It is based on your former comments. > > I'll get to it. I'm pretty choked right now and actually trying to have > some vacation at the same time. > > In the meantime, after glancing over and noting prolific use of the > unlikely() macro, please read the following articles: > http://lwn.net/Articles/70473/ > http://lwn.net/Articles/420019/ >
These articles say the directives should be rarely used. Do you suggest to remove them from the patch?
Regards,
Sonic
| |