Messages in this thread | | | Date | Wed, 10 Jul 2013 06:29:16 +0300 | From | Eliezer Tamir <> | Subject | Re: [PATCH net-next] net: rename low latency sockets functions to busy poll |
| |
On 10/07/2013 02:06, David Miller wrote: > From: Jonathan Corbet <corbet@lwn.net> > Date: Tue, 9 Jul 2013 16:25:14 -0600 > >> On Mon, 08 Jul 2013 16:20:34 +0300 >> Eliezer Tamir <eliezer.tamir@linux.intel.com> wrote: >> >>> Rename POLL_LL to POLL_BUSY_LOOP. >> >> So pardon me if I speak out of turn, but it occurs to me to >> wonder...should the SO_LL socket option be renamed in a similar fashion >> before this interface escapes into the wild? > > Sure and we can rename include/net/ll_poll.h to something more > fitting as well. > > I'll make sure this happens before 3.11 gets even close to release.
David,
If the following names changes are acceptable I will try to send out a patch today.
1. include/net/ll_poll.h -> include/net/busy_poll.h
2. ndo_ll_poll -> ndo_busy_poll
- not technically accurate since the ndo callback does not itself busy poll, it's just used to implement it.
maybe ndo_napi_id_poll? or ndo_id_poll? I don't really like any of them, so a suggestion would be nice.
3. sysctl_net_ll_{read,poll} -> sysctl_net_busy_{read,poll} - along with matching file name changes.
4. {sk,skb}_mark_ll -> {sk,skb}_mark_napi_id
5. LL_SO -> BUSY_POLL_SO
Are you OK with the names? Did I miss anything?
Thanks, Eliezer
| |