Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH] perf: Update event buffer tail when overwriting old events | Date | Tue, 09 Jul 2013 15:18:20 +0900 |
| |
Hi Peter,
On Mon, 8 Jul 2013 14:15:57 +0200, Peter Zijlstra wrote: [SNIP] > +static void > +perf_event_set_overflow(struct perf_event *event, struct ring_buffer *rb) > +{ > + if (event->overflow_handler != perf_event_output ||
I guess you wanted "&&" instead of "||" here.
Thanks, Namhyung
> + event->overflow_handler != perf_event_output_overwrite) > + return; > + > + if (rb->overwrite) > + event->overflow_handler = perf_event_output_overwrite; > + else > + event->overflow_handler = perf_event_output; > +}
| |