lkml.org 
[lkml]   [2013]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2 0/4] Minor perf build fixes
Date
Hi Ramkumar,

On Fri, 5 Jul 2013 15:46:13 +0530, Ramkumar Ramachandra wrote:
> Hi,
>
> After Namhyung's review of the first iteration, I realized that I'd
> made a few mistakes. This iteration should be much better.
>
> [1/4] is the same as before.
>
> [2/4] is new, and is used in [4/4].
>
> [3/4] introduces a util/perf-perl.h to include <perl.h> with #pragma
> statements, hence eliminating duplication. It then updates Context.xs
> and trace-event-perl.c to use this new header.

I prefer the name being "perl.h" and use #include_next as we include the
'util' directory in the compiler search path.

Other than that, the change looks good to me.

>
> Also, notice that feature-tests.mak has not been touched in this
> iteration: the Perl check passes without needing the #pragma
> statements (although I'm not sure why exactly).

I guess it's because FLAGS_PERL_EMBED doesn't contain the usual perf
CFLAGS which has -Werror.

Thanks,
Namhyung

>
> Thanks.
>
> Ramkumar Ramachandra (4):
> perf/Makefile: do not open-code shell-sq
> perf/Perf-Trace-Util: fix broken include in Context.xs
> perf: squelch warnings from perl.h to compile-pass
> perf/Perf-Trace-Util: regenerate Context.c
>
> tools/perf/Makefile | 2 +-
> tools/perf/config/Makefile | 23 ++-
> tools/perf/scripts/perl/Perf-Trace-Util/Context.c | 215 +++++++++++++++++----
> tools/perf/scripts/perl/Perf-Trace-Util/Context.xs | 6 +-
> tools/perf/util/perf-perl.h | 10 +
> .../perf/util/scripting-engines/trace-event-perl.c | 2 +-
> 6 files changed, 199 insertions(+), 59 deletions(-)
> create mode 100644 tools/perf/util/perf-perl.h


\
 
 \ /
  Last update: 2013-07-10 23:27    [W:0.086 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site