Messages in this thread | | | Date | Tue, 9 Jul 2013 11:05:26 +0100 | From | Mark Brown <> | Subject | Re: [PATCHv3 2/3] drivers: spi: Add qspi flash controller |
| |
On Tue, Jul 09, 2013 at 09:51:43AM +0300, Felipe Balbi wrote:
> > Looks like a case to use regmap? > > Dumb q: why cant we use regmap_spi? worst case, you should be able to
> read regmap-spi and you'll see why it can't be used in this case.
> regmap-spi is for SPI clients who want to read their register map > through SPI commands. This is a driver for the SPI master which has its > registers memory mapped.
Indeed, regmap-spi would be a client of this driver. Though there is regmap-mmio which may be helpful, on the other hand it's relatively heavyweight and SPI can be a bit performance sensitive so perhaps it's not awesome here. Russell did mention the idea of some helpers along a similar style though, they may be a good idea but nobody wrote them yet. [unhandled content-type:application/pgp-signature] | |