Messages in this thread | | | Date | Wed, 31 Jul 2013 15:27:09 +0530 | From | "Naveen N. Rao" <> | Subject | Re: [PATCH] APEI/ERST: Fix error message formatting |
| |
On 07/29/2013 08:52 PM, Borislav Petkov wrote: > @@ -186,8 +186,8 @@ static int erst_exec_stall(struct apei_exec_context *ctx, > > if (ctx->value > FIRMWARE_MAX_STALL) { > if (!in_nmi()) > - pr_warning(FW_WARN ERST_PFX > - "Too long stall time for stall instruction: %llx.\n", > + pr_warn(FW_WARN > + "Too long stall time for stall instruction: 0x%llx.\n",
A minor nit: %#llx to stay consistent with the other changes later on.
> ctx->value); > stall_time = FIRMWARE_MAX_STALL; > } else > @@ -206,8 +206,8 @@ static int erst_exec_stall_while_true(struct apei_exec_context *ctx, > > if (ctx->var1 > FIRMWARE_MAX_STALL) { > if (!in_nmi()) > - pr_warning(FW_WARN ERST_PFX > - "Too long stall time for stall while true instruction: %llx.\n", > + pr_warn(FW_WARN > + "Too long stall time for stall while true instruction: 0x%llx.\n",
Ditto.
Thanks, Naveen
| |