lkml.org 
[lkml]   [2013]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] APEI/ERST: Fix error message formatting
    On 07/29/2013 08:52 PM, Borislav Petkov wrote:
    > @@ -186,8 +186,8 @@ static int erst_exec_stall(struct apei_exec_context *ctx,
    >
    > if (ctx->value > FIRMWARE_MAX_STALL) {
    > if (!in_nmi())
    > - pr_warning(FW_WARN ERST_PFX
    > - "Too long stall time for stall instruction: %llx.\n",
    > + pr_warn(FW_WARN
    > + "Too long stall time for stall instruction: 0x%llx.\n",

    A minor nit: %#llx to stay consistent with the other changes later on.

    > ctx->value);
    > stall_time = FIRMWARE_MAX_STALL;
    > } else
    > @@ -206,8 +206,8 @@ static int erst_exec_stall_while_true(struct apei_exec_context *ctx,
    >
    > if (ctx->var1 > FIRMWARE_MAX_STALL) {
    > if (!in_nmi())
    > - pr_warning(FW_WARN ERST_PFX
    > - "Too long stall time for stall while true instruction: %llx.\n",
    > + pr_warn(FW_WARN
    > + "Too long stall time for stall while true instruction: 0x%llx.\n",

    Ditto.


    Thanks,
    Naveen



    \
     
     \ /
      Last update: 2013-07-31 12:21    [W:3.869 / U:0.336 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site