lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH resend] drop_caches: add some documentation and info message
On Mon 29-07-13 13:57:43, Andrew Morton wrote:
> On Fri, 26 Jul 2013 14:44:29 +0200 Michal Hocko <mhocko@suse.cz> wrote:
[...]
> > --- a/fs/drop_caches.c
> > +++ b/fs/drop_caches.c
> > @@ -59,6 +59,8 @@ int drop_caches_sysctl_handler(ctl_table *table, int write,
> > if (ret)
> > return ret;
> > if (write) {
> > + printk(KERN_INFO "%s (%d): dropped kernel caches: %d\n",
> > + current->comm, task_pid_nr(current), sysctl_drop_caches);
> > if (sysctl_drop_caches & 1)
> > iterate_supers(drop_pagecache_sb, NULL);
> > if (sysctl_drop_caches & 2)
>
> How about we do
>
> if (!(sysctl_drop_caches & 4))
> printk(....)
>
> so people can turn it off if it's causing problems?

I am OK with that but can we use a top bit instead. Maybe we never have
other entities to drop in the future but it would be better to have a room for them
just in case. So what about using 1<<31 instead?


--
Michal Hocko
SUSE Labs


\
 
 \ /
  Last update: 2013-07-30 10:01    [W:0.092 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site