lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 08/10] ARM: sun7i: DT: Add UART muxing options to the DTSI
Hello.

On 07/30/2013 06:59 PM, Maxime Ripard wrote:

> The UARTs on the A20 can be muxed to several pins. Add a few options to
> the DTSI so that we can start using them in the boards' DT.

> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> ---
> arch/arm/boot/dts/sun7i-a20.dtsi | 21 +++++++++++++++++++++
> 1 file changed, 21 insertions(+)

> diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
> index 704fca9..9f45e8d 100644
> --- a/arch/arm/boot/dts/sun7i-a20.dtsi
> +++ b/arch/arm/boot/dts/sun7i-a20.dtsi
> @@ -70,6 +70,27 @@
> #address-cells = <1>;
> #size-cells = <0>;
> #gpio-cells = <3>;
> +
> + uart0_pins_a: uart0@0 {

Why have address part of the node name if there's not "reg" property?
And the preferred node name is "serial", not "uart", according to the ePAPR
spec (http://www.power.org/resources/downloads/Power_ePAPR_APPROVED_v1.0.pdf).

> + allwinner,pins = "PB22", "PB23";
> + allwinner,function = "uart0";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + uart6_pins_a: uart6@0 {
> + allwinner,pins = "PI12", "PI13";
> + allwinner,function = "uart6";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };
> +
> + uart7_pins_a: uart7@0 {
> + allwinner,pins = "PI20", "PI21";
> + allwinner,function = "uart7";
> + allwinner,drive = <0>;
> + allwinner,pull = <0>;
> + };

WBR, Sergei



\
 
 \ /
  Last update: 2013-07-30 22:21    [W:0.049 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site