lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 45/75] sparc: tsb must be flushed before tlb
    Date
    3.8.13.6 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dave Kleikamp <dave.kleikamp@oracle.com>

    commit 23a01138efe216f8084cfaa74b0b90dd4b097441 upstream.

    This fixes a race where a cpu may re-load a tlb from a stale tsb right
    after it has been flushed by a remote function call.

    I still see some instability when stressing the system with parallel
    kernel builds while creating memory pressure by writing to
    /proc/sys/vm/nr_hugepages, but this patch improves the stability
    significantly.

    Signed-off-by: Dave Kleikamp <dave.kleikamp@oracle.com>
    Acked-by: Bob Picco <bob.picco@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Kamal Mostafa <kamal@canonical.com>
    ---
    arch/sparc/mm/tlb.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/arch/sparc/mm/tlb.c b/arch/sparc/mm/tlb.c
    index 83d89bc..37e7bc4 100644
    --- a/arch/sparc/mm/tlb.c
    +++ b/arch/sparc/mm/tlb.c
    @@ -85,8 +85,8 @@ static void tlb_batch_add_one(struct mm_struct *mm, unsigned long vaddr,
    }

    if (!tb->active) {
    - global_flush_tlb_page(mm, vaddr);
    flush_tsb_user_page(mm, vaddr);
    + global_flush_tlb_page(mm, vaddr);
    goto out;
    }

    --
    1.8.1.2


    \
     
     \ /
      Last update: 2013-07-30 21:41    [W:4.177 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site