lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC PATCH - diffstat only] include/net: Remove extern from function prototypes
Hi Joe,

On Tue, 30 Jul 2013 00:10:01 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
>
> From: Joe Perches <joe@perches.com>
> Date: Tue, 23 Jul 2013 10:58:11 -0700
>
> > Function prototypes don't need to be declared
> > extern in .h files. It's assumed by the compiler
> > and is as unnecessary as using auto is when
> > declaring automatic/local variables in a block.
> >
> > I ran a script to remove these unnecessary extern
> > uses from function prototypes in include/net/ as
> > well as reflow the function arguments to 80 cols.
> >
> > It's 370KB, far too large to submit at once.
> >
> > Of course it could be broken into multiple patches
> > for the various directories/subsystems.
>
> No objections from me.

I must admit I prefer the other way (i.e. with the explicit extern). If
nothing else it makes it consistent with variable declarations in header
files (which need the extern) and "static inlines" ...

Making these churn changes also will almost certainly cause unnecessary
conflicts :-(

--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-07-30 09:41    [W:0.053 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site