lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3 1/3] net/usb/r815x: replace USB buffer from stack to DMA-able
From
Date
On Tue, 2013-07-30 at 11:33 -0700, David Miller wrote:
> From: Greg KH <gregkh@linuxfoundation.org>
> Date: Tue, 30 Jul 2013 07:00:59 -0700
>
> > This call is so slow, you can afford to make a call to kmalloc for the
> > data, as it sure just did for other structures it needed :)
>
> I told him to implement things this way, to avoid calling kmalloc every
> single register access.
>
> Using kmalloc all the time makes the access fragile, since a badly timed
> call during high memory pressure can fail.
>
> I'd rather the potential failure happen at one time, probe time.
>
> In any event, Ming Lei has suggested using usbnet_{read,write}_cmd()
> instead, which sounds like a good solution to this problem.

Those do per-call allocs too.




\
 
 \ /
  Last update: 2013-07-30 21:01    [W:0.056 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site