Messages in this thread | | | Date | Wed, 3 Jul 2013 10:33:04 -0400 | From | Jason Cooper <> | Subject | Re: [PATCH v6 5/7] ARM: kirkwood: remove redundant DT board files |
| |
On Wed, Jul 03, 2013 at 01:31:47PM +0200, Sebastian Hesselbarth wrote: > On 07/03/13 01:09, Arnaud Ebalard wrote: > >Hi Sebastian, > > > >Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> writes: > > > >>With DT support for mv643xx_eth board specific init for some boards now > >>is unneccessary. Remove those board files, Kconfig entries, and > >>corresponding entries in kirkwood_defconfig. > > > >Applying above your set an old quilt cleaning patch Jason asked at some > >point, it became empty except for arch/arm/mach_kirkwood/common.h in > >which some declarations were left behind. If this is correct, can you > >just merge the hunks below in your 5/7 in next round? > > > >AFAICT, only dnskw_init() remains, which matches the list of board-*.c > >files in arch/arm/mach_kirkwood/ (i.e. board-dt.c and board-dnskw.c). > > While updating the patch with yours, I stumbled upon MACH_TS219_DT that > also remains because it includes tsx1x-common.c. > > I cannot recall if Jason or Andrew said something about removing it..
board-ts219.c can be removed as well. It needed a check for running on the 6282 variant in order to set the phy address properly. This can now be handled in kirkwood-ts219-628[12].dts.
thx,
Jason.
| |