Messages in this thread |  | | Date | Fri, 26 Jul 2013 12:58:02 +0530 | Subject | Re: [PATCH v6 3/8] cpufreq:acpi:x86: Adjust the acpi-cpufreq.c code to work with common boost solution | From | Viresh Kumar <> |
| |
On 25 July 2013 22:03, Lukasz Majewski <l.majewski@samsung.com> wrote: > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> static void __init acpi_cpufreq_boost_init(void) > { > + acpi_cpufreq_driver.boost_supported = false;
Would be better if we do this in else of below if.
> if (boot_cpu_has(X86_FEATURE_CPB) || boot_cpu_has(X86_FEATURE_IDA)) { > msrs = msrs_alloc();
> @@ -1021,12 +995,11 @@ static int __init acpi_cpufreq_init(void) > *iter = &cpb; > } > #endif > + acpi_cpufreq_boost_init();
We are calling it before registering cpufreq driver. Will this have any complications?
> ret = cpufreq_register_driver(&acpi_cpufreq_driver); > if (ret) > free_acpi_perf_data(); > - else > - acpi_cpufreq_boost_init(); > > return ret;
|  |