lkml.org 
[lkml]   [2013]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v6 1/8] cpufreq: Store cpufreq policies in a list
    On Fri, 26 Jul 2013 15:44:29 +0530 Viresh Kumar viresh.kumar@linaro.org
    wrote,
    > On 25 July 2013 22:03, Lukasz Majewski <l.majewski@samsung.com> wrote:
    > > Policies available in a cpufreq framework are now linked together.
    > > They are accessible via cpufreq_policy_list defined at cpufreq core.
    > >
    > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com>
    > > Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com>
    >
    > Looks good but would have been better if you could have moved
    > existing code to use this infrastructure..
    >
    > For example, this code in __cpufreq_add_dev()
    >
    > #ifdef CONFIG_HOTPLUG_CPU
    > /* Check if this cpu was hot-unplugged earlier and has
    > siblings */ read_lock_irqsave(&cpufreq_driver_lock, flags);
    > for_each_online_cpu(sibling) {
    >
    > ---
    >
    > }
    > read_unlock_irqrestore(&cpufreq_driver_lock, flags);
    > #endif

    Do you mean to write something like:

    #ifdef CONFIG_CPU_FREQ_BOOST_SW
    write_lock_irqsave(&cpufreq_driver_lock, flags);
    list_add(&policy->policy_list, &cpufreq_policy_list);
    write_unlock_irqrestore(&cpufreq_driver_lock, flags);
    #endif

    Or Am I missing something?
    --
    Best regards,

    Lukasz Majewski

    Samsung R&D Institute Poland (SRPOL) | Linux Platform Group


    \
     
     \ /
      Last update: 2013-07-26 13:21    [W:4.191 / U:0.204 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site