Messages in this thread |  | | Date | Fri, 26 Jul 2013 15:54:56 +0530 | Subject | Re: [PATCH v6 5/8] cpufreq:boost:Kconfig: Provide support for software managed BOOST | From | Viresh Kumar <> |
| |
On 25 July 2013 22:03, Lukasz Majewski <l.majewski@samsung.com> wrote: > For safety reasons new flag - CONFIG_CPU_FREQ_BOOST_SW has been added. > Only after selecting "EXYNOS Frequency Overclocking - Software" Kconfig
You shouldn't mention Exynos here and must do exynos stuff at the end in a separate patch. This one must be generic.
> option the software managed boost is enabled. It also selects thermal > subsystem to be compiled in. Thermal is necessary for disabling boost > and cooling down the device when overheating detected. > > Boost _MUST_NOT_ work without thermal subsystem with properly defined > overheating temperatures. > > This option doesn't affect x86's ACPI hardware managed boost support > (i.e. Intel, AMD). In this situation boost management is embedded at > hardware. > > Signed-off-by: Lukasz Majewski <l.majewski@samsung.com> > Signed-off-by: Myungjoo Ham <myungjoo.ham@samsung.com> > > --- > Changes for v6: > - CPU_FREQ_BOOST_SW [1] is now defined as "invisible" bool option. > - Platform dependent ARM_EXYNOS_CPU_FREQ_BOOST_SW config option has been > added. It depends on ARM_EXYNOS_CPUFREQ options and selects > EXYNOS_THERMAL with the main boost config [1]. > > Changes for v5: > - New patch > > drivers/cpufreq/Kconfig | 3 +++ > drivers/cpufreq/Kconfig.arm | 16 ++++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig > index 534fcb8..3f058a3 100644 > --- a/drivers/cpufreq/Kconfig > +++ b/drivers/cpufreq/Kconfig > @@ -23,6 +23,9 @@ config CPU_FREQ_TABLE > config CPU_FREQ_GOV_COMMON > bool > > +config CPU_FREQ_BOOST_SW > + bool
Invisible is fine but this must be disabled by default and must depend on thermal, rather than moving dependency on platform's config.
|  |