lkml.org 
[lkml]   [2013]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v6 2/8] cpufreq: Add boost frequency support in core
    From
    On 26 July 2013 14:03, Lukasz Majewski <l.majewski@samsung.com> wrote:
    > The problem here is with the cpufreq_driver->set_boost() call.
    >
    > I tried to avoid acquiring lock at one function and release it at
    > another (in this case cpufreq_boost_set_sw), especially since the
    > __cpufreq_governor() acquires its own lock - good place for deadlock.
    >
    > Is it OK for you to grab lock at one function
    > (cpufreq_boost_trigger_state()) and then at other function
    > (cpufreq_boost_set_sw) release it before calling __cpufreq_governor()
    > and grab it again after its completion?

    Problem is not only that.. but we shouldn't call boost_set() of drivers
    like acpi-cpufreq with this lock..... Leave it as it is for now.. Let me see
    if I can think of any problems that can happen due to this.


    \
     
     \ /
      Last update: 2013-07-26 12:21    [W:3.660 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site