Messages in this thread | | | Date | Thu, 25 Jul 2013 11:09:13 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH 17/21] page_alloc, mem-hotplug: Improve movablecore to {en|dis}able using SRAT. |
| |
Hello, Tang.
On Thu, Jul 25, 2013 at 11:50:12AM +0800, Tang Chen wrote: > movablecore boot option was used to specify the size of ZONE_MOVABLE. And > this patch-set aims to arrange ZONE_MOVABLE with SRAT info. So my original > thinking is to reuse movablecore. > > Since you said above, I think we have two problems here: > 1. Should not let users care about where the hotplug info comes from. > 2. Should not distinguish movable node and memory hotplug, since for now, > to use memory hotplug is to use movable node. > > So how about something like "movablenode", just like "quiet" boot option. > If users specify "movablenode", then memblock will reserve hotpluggable > memory, and create movable nodes if any. If users specify nothing, then > the kernel acts as before.
Maybe I'm confused but memory hotplug isn't likely to work without this, right? If so, wouldn't it make more sense to have "memory_hotplug" option rather than "movablecore=acpi" which in no way indicates that it has something to do with memory hotplug?
Thanks.
-- tejun
| |