Messages in this thread | | | Date | Wed, 24 Jul 2013 15:43:01 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 04/10] powerpc: Prepare to support kernel handling of IOMMU map/unmap |
| |
On Tue, 23 Jul 2013 12:22:59 +1000 Alexey Kardashevskiy <aik@ozlabs.ru> wrote:
> Ping, anyone, please?
ew, you top-posted.
> Ben needs ack from any of MM people before proceeding with this patch. Thanks!
For what? The three lines of comment in page-flags.h? ack :)
Manipulating page->_count directly is considered poor form. Don't blame us if we break your code ;)
Actually, the manipulation in realmode_get_page() duplicates the existing get_page_unless_zero() and the one in realmode_put_page() could perhaps be placed in mm.h with a suitable name and some documentation. That would improve your form and might protect the code from getting broken later on.
| |