Messages in this thread | | | Subject | Re: [PATCH] mac80211: use oneshot blink API for LED triggers | From | Johannes Berg <> | Date | Wed, 24 Jul 2013 10:14:25 +0200 |
| |
On Wed, 2013-07-24 at 02:09 +0200, Fabio Baltieri wrote: > Changes mac80211 LED trigger code to use the generic > led_trigger_blink_oneshot() API for transmit and receive activity > indication. > > This gives a better feedback to the user, as with the new API each > activity event results in a visible blink, while a constant traffic > results in a continuous blink at constant rate.
This seems a little pointless since our throughput-based trigger can do very similar (but somewhat better) behaviour? Maybe that should just be the default instead, with some sane default setup values?
(Regardless of that, you also have indentation problems in your patch)
johannes
| |