Messages in this thread | | | From | "Zheng, Lv" <> | Subject | RE: [PATCH 01/13] ACPI/IPMI: Fix potential response buffer overflow | Date | Wed, 24 Jul 2013 00:21:42 +0000 |
| |
> From: linux-acpi-owner@vger.kernel.org > [mailto:linux-acpi-owner@vger.kernel.org] On Behalf Of Greg KH > Sent: Tuesday, July 23, 2013 10:54 PM > > On Tue, Jul 23, 2013 at 04:08:59PM +0800, Lv Zheng wrote: > > This patch enhances sanity checks on message size to avoid potential > > buffer overflow. > > > > The kernel IPMI message size is IPMI_MAX_MSG_LENGTH(272 bytes) while > > the ACPI specification defined IPMI message size is 64 bytes. The > > difference is not handled by the original codes. This may cause crash > > in the response handling codes. > > This patch fixes this gap and also combines rx_data/tx_data to use > > single data/len pair since they need not be seperated. > > > > Signed-off-by: Lv Zheng <lv.zheng@intel.com> > > Reviewed-by: Huang Ying <ying.huang@intel.com> > > --- > > drivers/acpi/acpi_ipmi.c | 100 > > ++++++++++++++++++++++++++++------------------ > > 1 file changed, 61 insertions(+), 39 deletions(-) > > <formletter> > > This is not the correct way to submit patches for inclusion in the stable kernel > tree. Please read Documentation/stable_kernel_rules.txt > for how to do this properly. > > </formletter> > > Same goes for the other patches you sent in this thread...
OK, I'll add prerequisites for each that want to be accepted by the stable queue and re-send them (PATCH 01-06).
Thanks and best regards -Lv
> -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body > of a message to majordomo@vger.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html
| |