lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/21] acpi: Print Hot-Pluggable Field in SRAT.
On Tue, Jul 23, 2013 at 12:15:58PM -0700, Joe Perches wrote:
> > The following would be more conventional.
> >
> > "...10Lx]%s\n", ..., hotpluggable ? " Hot Pluggable" : ""
> >
> > Also, isn't "Hot Pluggable" a bit too verbose? "hotplug" should be
> > fine, I think.
>
> It's also a tiny nit better to use:
>
> pr_info("SRAT: Node %u PXM %u [mem %#010Lx-%#010Lx]%s\n",
> node, pxm,
> (unsigned long long) start, (unsigned long long) end - 1,
> hotpluggable ? " Hot Pluggable" : "");
>
> (or " hotplug")
>
> so there's no space before newline.

Which was my first point which apparently wasn't clear enough. :)

Thanks.

--
tejun


\
 
 \ /
  Last update: 2013-07-23 22:21    [W:0.072 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site