lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH, RFC] sched: update_top_cache_domain only at the times of building sched domain.
On Tue, Jul 23, 2013 at 10:20:20PM +0600, Rakib Mullick wrote:

> You mean using sd == NULL rather than using update_cache_domain variable ?

Yes, note how:

@@ -6109,7 +6110,7 @@ static void detach_destroy_domains(const struct cpumask *cpu_map)

rcu_read_lock();
for_each_cpu(i, cpu_map)
- cpu_attach_domain(NULL, &def_root_domain, i);
rcu_read_unlock();
}

Always has NULL for sd? Which means you can do:

@@ -5138,7 +5138,8 @@ cpu_attach_domain(struct sched_domain *sd, struct root_domain *rd, int cpu)
rcu_assign_pointer(rq->sd, sd);
destroy_sched_domains(tmp, cpu);

- update_top_cache_domain(cpu);
+ if (sd)
+ update_top_cache_domain(cpu);
}

/* cpus with isolated domains */

\
 
 \ /
  Last update: 2013-07-23 19:41    [W:0.080 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site