lkml.org 
[lkml]   [2013]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v3] ARM: kirkwood: extend the kirkwood i2s driver for DT usage
    On 07/23/2013 10:53 AM, Russell King - ARM Linux wrote:
    > On Tue, Jul 23, 2013 at 10:46:15AM +0200, Jean-Francois Moine wrote:
    >> The kirkwood i2s driver is used without DT in the Kirkwood machine.
    >> This patch adds a DT compatible definition for use in other Marvell
    >> machines as the Armada 88AP510 (Dove).
    >
    > Yet again, this illustrates why converting to DT causes backwards
    > steps in drivers: the conversion of devm_clk_get() to of_clk_get()
    > necessitates a clk_put().

    That's just a very poor usage of the API in this patch. devm_clk_get() works
    fine on DT and non-DT platforms. The driver shouldn't need any changes in
    that regard.

    - Lars



    \
     
     \ /
      Last update: 2013-07-23 11:41    [W:3.938 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site