lkml.org 
[lkml]   [2013]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 58/72] ext4: dont allow ext4_free_blocks() to fail due to ENOMEM
    Date
    3.10-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Theodore Ts'o <tytso@mit.edu>

    commit e7676a704ee0a1ef71a6b23760b5a8f6896cb1a1 upstream.

    The filesystem should not be marked inconsistent if ext4_free_blocks()
    is not able to allocate memory. Unfortunately some callers (most
    notably ext4_truncate) don't have a way to reflect an error back up to
    the VFS. And even if we did, most userspace applications won't deal
    with most system calls returning ENOMEM anyway.

    Reported-by: Nagachandra P <nagachandra@gmail.com>
    Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/mballoc.c | 11 ++++++++---
    1 file changed, 8 insertions(+), 3 deletions(-)

    --- a/fs/ext4/mballoc.c
    +++ b/fs/ext4/mballoc.c
    @@ -4735,11 +4735,16 @@ do_more:
    * blocks being freed are metadata. these blocks shouldn't
    * be used until this transaction is committed
    */
    + retry:
    new_entry = kmem_cache_alloc(ext4_free_data_cachep, GFP_NOFS);
    if (!new_entry) {
    - ext4_mb_unload_buddy(&e4b);
    - err = -ENOMEM;
    - goto error_return;
    + /*
    + * We use a retry loop because
    + * ext4_free_blocks() is not allowed to fail.
    + */
    + cond_resched();
    + congestion_wait(BLK_RW_ASYNC, HZ/50);
    + goto retry;
    }
    new_entry->efd_start_cluster = bit;
    new_entry->efd_group = block_group;



    \
     
     \ /
      Last update: 2013-07-19 08:22    [W:6.722 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site