lkml.org 
[lkml]   [2013]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf util: Rename read_*() functions in trace-event-info.c
    Commit-ID:  077f159d0402ac90a3ea9975f4089a042e0be065
    Gitweb: http://git.kernel.org/tip/077f159d0402ac90a3ea9975f4089a042e0be065
    Author: Namhyung Kim <namhyung.kim@lge.com>
    AuthorDate: Tue, 4 Jun 2013 14:20:29 +0900
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Fri, 12 Jul 2013 13:52:30 -0300

    perf util: Rename read_*() functions in trace-event-info.c

    It's confusing to have same name for two difference functions which does
    something opposite way. Since what they do in this file is read *AND*
    writing some of tracing metadata files, rename them to record_*() looks
    better to me.

    Signed-off-by: Namhyung Kim <namhyung@kernel.org>
    Cc: David Ahern <dsahern@gmail.com>
    Cc: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Jiri Olsa <jolsa@redhat.com>
    Cc: Paul Mackerras <paulus@samba.org>
    Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Link: http://lkml.kernel.org/r/1370323231-14022-15-git-send-email-namhyung@kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/trace-event-info.c | 20 ++++++++++----------
    1 file changed, 10 insertions(+), 10 deletions(-)

    diff --git a/tools/perf/util/trace-event-info.c b/tools/perf/util/trace-event-info.c
    index a42624a..a800f2b 100644
    --- a/tools/perf/util/trace-event-info.c
    +++ b/tools/perf/util/trace-event-info.c
    @@ -101,7 +101,7 @@ out:
    return err;
    }

    -static int read_header_files(void)
    +static int record_header_files(void)
    {
    char *path;
    struct stat st;
    @@ -240,7 +240,7 @@ out:
    return err;
    }

    -static int read_ftrace_files(struct tracepoint_path *tps)
    +static int record_ftrace_files(struct tracepoint_path *tps)
    {
    char *path;
    int ret;
    @@ -269,7 +269,7 @@ static bool system_in_tp_list(char *sys, struct tracepoint_path *tps)
    return false;
    }

    -static int read_event_files(struct tracepoint_path *tps)
    +static int record_event_files(struct tracepoint_path *tps)
    {
    struct dirent *dent;
    struct stat st;
    @@ -344,7 +344,7 @@ out:
    return err;
    }

    -static int read_proc_kallsyms(void)
    +static int record_proc_kallsyms(void)
    {
    unsigned int size;
    const char *path = "/proc/kallsyms";
    @@ -362,7 +362,7 @@ static int read_proc_kallsyms(void)
    return record_file(path, 4);
    }

    -static int read_ftrace_printk(void)
    +static int record_ftrace_printk(void)
    {
    unsigned int size;
    char *path;
    @@ -539,19 +539,19 @@ struct tracing_data *tracing_data_get(struct list_head *pattrs,
    err = tracing_data_header();
    if (err)
    goto out;
    - err = read_header_files();
    + err = record_header_files();
    if (err)
    goto out;
    - err = read_ftrace_files(tps);
    + err = record_ftrace_files(tps);
    if (err)
    goto out;
    - err = read_event_files(tps);
    + err = record_event_files(tps);
    if (err)
    goto out;
    - err = read_proc_kallsyms();
    + err = record_proc_kallsyms();
    if (err)
    goto out;
    - err = read_ftrace_printk();
    + err = record_ftrace_printk();

    out:
    /*

    \
     
     \ /
      Last update: 2013-07-19 12:41    [W:4.220 / U:0.356 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site