Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 4/30] ACPI / hotplug / PCI: Hotplug context objects for bridges and functions | Date | Thu, 18 Jul 2013 22:06:16 +0200 |
| |
On Thursday, July 18, 2013 09:04:11 PM Rafael J. Wysocki wrote: > On Wednesday, July 17, 2013 07:00:33 PM Yinghai Lu wrote: > > On Wed, Jul 17, 2013 at 4:17 PM, Rafael J. Wysocki <rjw@sisk.pl> wrote: > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > > > > When either a new hotplug bridge or a new hotplug function is added > > > by the ACPI-based PCI hotplug (ACPIPHP) code, attach a context object > > > to its ACPI handle to store hotplug-related information in it. To > > > start with, put the handle's bridge and function pointers into that > > > object. Count references to the context objects and drop them when > > > they are not needed any more. > > > > > > First of all, this makes it possible to find out if the given bridge > > > has been registered as a function already in a much more > > > straightforward way and acpiphp_bridge_handle_to_function() can be > > > dropped (Yay!). > > > > > > This also will allow some more simplifications to be made going > > > forward. > > > > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > > --- > > > drivers/pci/hotplug/acpiphp.h | 10 ++ > > > drivers/pci/hotplug/acpiphp_glue.c | 179 ++++++++++++++++++++++++++++--------- > > > 2 files changed, 146 insertions(+), 43 deletions(-) > > > > no, more lines are added. > > Well, that's what 'quilt refresh --diffstat' tells me, quite consistently. > > Have you actually counted them?
Now I have done that (using "grep '^+' | wc -l") and that indeed turns out ot the right number.
What gives?
Rafael
-- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.
| |