lkml.org 
[lkml]   [2013]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v3] power: new trace event to print device suspend and resume time
From
Date
On Thu, 2013-07-18 at 14:00 +0000, Shuah Khan wrote:

> >
> > Don't you want to convert the ops_time on display? You can have:
> >
> > TP_printk("%s %s parent=%s state=%s ops=%snsecs=%lld err=%d",
> > __get_str(driver), __get_str(device), __get_str(parent),
> > __get_str(pm_event_str), __get_str(pm_ops),
> > ktime_to_ns(__entry->ops_time), __entry->error)
> >
> >
> > -- Steve
>
> I decided to pass in the converted value to the tracepoint. Please see
> the drivers/base/power/main.c call to trace_device_pm_report_time()

But why? You are still doing the calculation in the fast path. The
TP_printk() is in the slow path. Why add overhead to the execution of
the code?

-- Steve

>
> +
> + trace_device_pm_report_time(dev_name(dev), dev_driver_string(dev),
> + dev->parent ? dev_name(dev->parent) : "none",
> + info ? info : "none ",
> + (s64) ktime_to_ns(delta), pm_verb(state.event),
> + error);
>
> -- Shuah
>
> Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research
> America (Silicon Valley) shuah.kh@samsung.com | (970) 672-0658




\
 
 \ /
  Last update: 2013-07-18 17:01    [W:0.042 / U:2.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site