lkml.org 
[lkml]   [2013]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/30] ACPI / hotplug / PCI: Always return success after adding a function
    Date
    From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

    When a new ACPIPHP function is added by register_slot() and the
    notify handler cannot be installed for it, register_slot() returns an
    error status without cleaning up, which causes the entire namespace
    walk in acpiphp_enumerate_slots() to be aborted, although it still
    may be possible to successfully install the function notify handler
    for other device objects under the given brigde.

    To address this issue make register_slot() return success after
    a new function has been added, even if the addition of the notify
    handler for it has failed.

    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    ---
    drivers/pci/hotplug/acpiphp_glue.c | 5 ++---
    1 file changed, 2 insertions(+), 3 deletions(-)

    Index: linux-pm/drivers/pci/hotplug/acpiphp_glue.c
    ===================================================================
    --- linux-pm.orig/drivers/pci/hotplug/acpiphp_glue.c
    +++ linux-pm/drivers/pci/hotplug/acpiphp_glue.c
    @@ -325,10 +325,9 @@ register_slot(acpi_handle handle, u32 lv

    if (ACPI_FAILURE(status))
    err("failed to register interrupt notify handler\n");
    - } else
    - status = AE_OK;
    + }

    - return status;
    + return AE_OK;

    err_exit:
    bridge->nr_slots--;


    \
     
     \ /
      Last update: 2013-07-19 03:42    [W:4.310 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site