Messages in this thread | | | Date | Wed, 17 Jul 2013 14:08:25 -0400 | From | Naoya Horiguchi <> | Subject | Re: [PATCH] mm/swap.c: clear PageActive before adding pages onto unevictable list (Re: 3.11.0-rc1: kernel BUG at mm/migrate.c:458 in page migration) |
| |
On Wed, Jul 17, 2013 at 09:02:49PM +0300, Kirill A. Shutemov wrote: ... > > --- > > From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > > Date: Wed, 17 Jul 2013 11:49:56 -0400 > > Subject: [PATCH] mm/swap.c: clear PageActive before adding pages onto > > unevictable list > > > > As a result of v3.10-3600-g13f7f78 "mm: pagevec: defer deciding which LRU > > to add a page to until pagevec drain time," pages on unevictable lists can > > have both of PageActive and PageUnevictable set. This is not only confusing, > > but also corrupts page migration and shrink_[in]active_list. > > > > This patch fixes the problem by adding ClearPageActive before adding pages > > into unevictable list. It also cleans up VM_BUG_ONs. > > > > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> > > Cc: stable@vger.kernel.org # 3.10 > > Looks good to me. > > Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Thanks.
> One more patch related to the topic: > > https://lkml.org/lkml/2013/7/15/140
Yes, that's why I added CC to you :)
Naoya
| |