lkml.org 
[lkml]   [2013]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] Squashfs: sanity check information from disk
On Wed, Jul 17, 2013 at 05:20:31AM +0100, Phillip Lougher wrote:
> On 15 July 2013 17:17, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > We read the size of the name from the disk, but a larger name than
> > expected would cause memory corruption.
>
> Thanks for the patch, it's queued for the next merge window. There's
> one mistake with the patch, but I can fix it when it's applied, or you
> can send a revised patch (see later).

I wouldn't call it a "mistake", it's just a difference in prefered
styles. The two statements:

if (size >= SQUASHFS_NAME_LEN + 1) {
and
if (size > SQUASHFS_NAME_LEN) {

These statements are equivalent. But I can change it, no worries.

regards,
dan carpenter



\
 
 \ /
  Last update: 2013-07-17 15:01    [W:0.047 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site