lkml.org 
[lkml]   [2013]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 0/5] Davinci VPBE use devres and some cleanup
Date
Hi Prabhakar,

On Saturday 13 July 2013 14:20:26 Prabhakar Lad wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> This patch series replaces existing resource handling in the
> driver with managed device resource.

Thank you for the patches. They greatly simplify the probe/remove functions, I
like that. For patches 1 to 4,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I have the same concern as Joe Perches for patch 5.

> Lad, Prabhakar (5):
> media: davinci: vpbe_venc: convert to devm_* api
> media: davinci: vpbe_osd: convert to devm_* api
> media: davinci: vpbe_display: convert to devm* api
> media: davinci: vpss: convert to devm* api
> media: davinci: vpbe: Replace printk with dev_*
>
> drivers/media/platform/davinci/vpbe.c | 6 +-
> drivers/media/platform/davinci/vpbe_display.c | 23 ++----
> drivers/media/platform/davinci/vpbe_osd.c | 45 +++---------
> drivers/media/platform/davinci/vpbe_venc.c | 97 ++++-----------------
> drivers/media/platform/davinci/vpss.c | 62 ++++------------
> 5 files changed, 52 insertions(+), 181 deletions(-)

--
Regards,

Laurent Pinchart



\
 
 \ /
  Last update: 2013-07-17 15:01    [W:0.080 / U:2.828 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site