Messages in this thread | | | Date | Wed, 17 Jul 2013 11:10:59 +0900 | From | Masami Hiramatsu <> | Subject | Re: [RFC PATCH V2] tracing: Check f_dentry before accessing event_file/call in inode->i_private |
| |
(2013/07/16 3:16), Oleg Nesterov wrote: > On 07/09, Masami Hiramatsu wrote: >> >> To avoid this, when opening events/*/*/enable, we have to ensure >> the dentry of the file is not unlinked yet, under event_mutex >> is locked. > > Probably this can work, but I am starting to think that this ref > count becomes toooooo complex....
Oleg, I agree that is a bit complex way to fix but it can fix.
However, I think we should fix bugs first, because there are bugs. I don't like to leave a bug in the kernel as it is, while we re- start discussing new approach...
> Could you please look at the draft patch I sent in another email?
I'm happy to see the series, and I guess it will take a long discussion and review time again.
So, I'd like to suggest you getting these fixes into ftrace as first-aid treatment, and discuss your new series.
Thank you,
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |