Messages in this thread | | | From | "Kirill A. Shutemov" <> | Subject | Re: [PATCH 1/8] mm: drop actor argument of do_generic_file_read() | Date | Wed, 17 Jul 2013 02:13:27 +0300 (EEST) |
| |
Matthew Wilcox wrote: > On Mon, Jul 15, 2013 at 01:47:47PM +0300, Kirill A. Shutemov wrote: > > From: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> > > > > There's only one caller of do_generic_file_read() and the only actor is > > file_read_actor(). No reason to have a callback parameter. > > > > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> > > Acked-by: Dave Hansen <dave.hansen@linux.intel.com> > > Would it make sense to do the same thing to do_shmem_file_read()? > > From: Matthew Wilcox <willy@linux.intel.com> > > There's only one caller of do_shmem_file_read() and the only actor is > file_read_actor(). No reason to have a callback parameter. > > Signed-off-by: Matthew Wilcox <willy@linux.intel.com>
Looks good to me:
Reviewed-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
v3.11-rc1 brings one more user for read_actor_t -- lustre. But it seemes it's artifact of ages when f_op had ->sendfile and it's not in use anymore.
-- Kirill A. Shutemov
| |