Messages in this thread | | | Date | Tue, 16 Jul 2013 14:05:49 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH V6 06/12] perf tools: remove unnecessary callchain validation |
| |
On Tue, Jul 16, 2013 at 09:38:12AM +0300, Adrian Hunter wrote:
SNIP
> } > } > > -static int perf_session__preprocess_sample(struct perf_session *session, > - union perf_event *event, struct perf_sample *sample) > -{ > - if (event->header.type != PERF_RECORD_SAMPLE || > - !sample->callchain) > - return 0; > - > - if (!ip_callchain__valid(sample->callchain, event)) { > - pr_debug("call-chain problem with event, skipping it.\n"); > - ++session->stats.nr_invalid_chains; > - session->stats.total_invalid_chains += sample->period;
How about the '*invalid_chains' stats here? I dont see it incremented in the parsing routine.
Also the current behaviour is to increments stats for invalid callchains, but dont fail. With your changes we fail during the parsing.
On the other hand.. maybe we should fail ;-) I think that invalid callchain data is serious enough to be overlooked by not seeing the nr_invalid_chains got incremented.
let's see other comments and then silently push it :-)
jirka
| |