Messages in this thread |  | | Date | Tue, 16 Jul 2013 11:39:24 +0200 | From | Lukasz Majewski <> | Subject | Re: [PATCH v5 1/7] cpufreq: Store cpufreq policies in a list |
| |
On Tue, 16 Jul 2013 10:51:27 +0200 Viresh Kumar wrote, > On 4 July 2013 14:20, Lukasz Majewski <l.majewski@samsung.com> wrote: > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c > > > @@ -2056,6 +2058,7 @@ int cpufreq_unregister_driver(struct > > cpufreq_driver *driver) > > subsys_interface_unregister(&cpufreq_interface); > > unregister_hotcpu_notifier(&cpufreq_cpu_notifier); > > > > + list_del(&cpufreq_policy_list); > > You can't delete the list this way... You must have passed the list > entry you wanted to delete. More precisely link from the struct > cpufreq_policy.
Yes. I shouldn't delete statically defined head of the list. Thanks for spotting.
> > Over that, it shouldn't be done at the time of unregistering cpufreq > driver but as and when cpus are removed and _cpu_remove_dev > is called.
OK, I will iterate the list at __cpufreq_remove_dev() and remove each of them there.
-- Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
|  |