Messages in this thread | | | Subject | Re: [PATCH-v2 06/17] staging/lustre: remove HIPQUAD | From | Joe Perches <> | Date | Mon, 15 Jul 2013 06:38:49 -0700 |
| |
On Mon, 2013-07-15 at 21:08 +0800, Peng Tao wrote: [] > We should just remove HIPQUAD and replace it with %pI4.
HIPQUAD and NIPQUAD were host and network order variants. Perhaps you need %pI4h for the host uses?
> diff --git a/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c b/drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c [] > @@ -2574,8 +2574,8 @@ kiblnd_dev_need_failover(kib_dev_t *dev) > rc = rdma_resolve_addr(cmid, (struct sockaddr *)&srcaddr, > (struct sockaddr *)&dstaddr, 1); > if (rc != 0 || cmid->device == NULL) { > - CERROR("Failed to bind %s:%u.%u.%u.%u to device(%p): %d\n", > - dev->ibd_ifname, HIPQUAD(dev->ibd_ifip), > + CERROR("Failed to bind %s:%pI4 to device(%p): %d\n", > + dev->ibd_ifname, &dev->ibd_ifip, > cmid->device, rc);
Like this one?
| |