Messages in this thread | | | From | Alexander Shishkin <> | Subject | Re: [PATCH 6/6] [RFC] usb: gadget: USB_GADGET should depend on HAS_DMA | Date | Fri, 12 Jul 2013 10:39:18 +0300 |
| |
Alan Stern <stern@rowland.harvard.edu> writes:
> On Thu, 11 Jul 2013, Geert Uytterhoeven wrote: > >> If NO_DMA=y: >> >> drivers/built-in.o: In function `dma_set_coherent_mask': >> include/linux/dma-mapping.h:93: undefined reference to `dma_supported' >> include/linux/dma-mapping.h:93: undefined reference to `dma_supported' >> drivers/built-in.o: In function `usb_gadget_unmap_request': >> drivers/usb/gadget/udc-core.c:91: undefined reference to `dma_unmap_sg' >> drivers/usb/gadget/udc-core.c:96: undefined reference to `dma_unmap_single' >> drivers/built-in.o: In function `usb_gadget_map_request': >> drivers/usb/gadget/udc-core.c:62: undefined reference to `dma_map_sg' >> drivers/usb/gadget/udc-core.c:71: undefined reference to `dma_map_single' >> drivers/usb/gadget/udc-core.c:74: undefined reference to `dma_mapping_error' >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> --- >> This one is very debatable: probably the parts using the DMA API should >> be factored out, instead of disabling the whole USB gadget subsystem. > > Indeed. How does this look instead?
This one is much better. FWIW,
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Regards, -- Alex
| |