Messages in this thread | | | Date | Fri, 12 Jul 2013 22:12:56 +0100 | From | Ben Hutchings <> | Subject | Re: [PATCH 1/2] Drivers: hv: balloon: Fix a bug in the hot-add code |
| |
On Fri, Jul 12, 2013 at 09:07:19PM +0000, KY Srinivasan wrote: [...] > > Well now it might look like a bug that you don't test the result > > of wait_for_completion_timeout(). Maybe update the comment to > > explain why it's OK to continue anyway? > > I put in the comment in the patch explaining why it is ok to continue. [...]
But that is not nearly as easy to see as the comment that is already *in the code* which your patch isn't updating.
Ben.
-- Ben Hutchings We get into the habit of living before acquiring the habit of thinking. - Albert Camus
| |