Messages in this thread | | | Date | Thu, 11 Jul 2013 23:15:26 +0200 | From | Sylwester Nawrocki <> | Subject | Re: [PATCH RFC v3] media: OF: add video sync endpoint property |
| |
On 07/11/2013 01:41 PM, Prabhakar Lad wrote: [...] >>> diff --git a/drivers/media/v4l2-core/v4l2-of.c >>> b/drivers/media/v4l2-core/v4l2-of.c >>> index aa59639..1a54530 100644 >>> --- a/drivers/media/v4l2-core/v4l2-of.c >>> +++ b/drivers/media/v4l2-core/v4l2-of.c >>> @@ -100,6 +100,26 @@ static void v4l2_of_parse_parallel_bus(const struct >>> device_node *node, >>> if (!of_property_read_u32(node, "data-shift",&v)) >>> bus->data_shift = v; >>> >>> + if (!of_property_read_u32(node, "video-sync",&v)) { >>> + switch (v) { >>> + case V4L2_MBUS_VIDEO_SEPARATE_SYNC: >>> + flags |= V4L2_MBUS_VIDEO_SEPARATE_SYNC; >> >> >> I'm not convinced all those video sync types is something that really >> belongs >> to the flags field. In my understanding this field is supposed to hold only >> the _signal polarity_ information. >> >> > Ok, so there should be a function say v4l2_of_parse_signal_polarity() > to get the polarity alone then.
I don't think this is required, I would just extend v4l2_of_parse_parallel_bus() function to also handle sync-on-green-active property.
-- Thanks, Sylwester
| |