lkml.org 
[lkml]   [2013]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC 0/4] perf tools: Remove event types data
Date
On Tue,  9 Jul 2013 18:48:55 +0200, Jiri Olsa wrote:
> hi,
> following up on the 'perf timechart' FIXME note and changing
> its tracepoint match not to use event types data.
>
> In my tests the old and new timechart outputs look the same,
> so.. any other tester would be appreciated ;-)
>
> Also as this was the only user of the event types data
> the rest of the patchset is removing it out of the perf.
>
> The event types data are referenced from the perf data
> file header. The reference (offset & size) stays in the
> header with 0s.
>
> Also the event types data is already duplicated via the
> event_desc FEATURE, so there's no information loss.

I generally agree on removing the event_types but have a couple of
issues on patch 1. Please see my comments on it.

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-07-11 09:01    [W:0.182 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site