Messages in this thread | | | Subject | Re: [PATCH] sched: fix cpu utilization account error | From | Mike Galbraith <> | Date | Tue, 02 Jul 2013 05:07:54 +0200 |
| |
On Mon, 2013-07-01 at 19:26 +0800, Xie XiuQi wrote:
> Here is the kthread main logic. Although it's not a good idea, but it does > exist:
Why not fix this instead?
> while (!kthread_should_stop()) { > /* call schedule every 1 sec */ > if (HZ <= jiffies - last) { > last = jiffies; > schedule(); > }
Hanging out in the kernel for ages is not cool. That doesn't mean something else might not pop up that forces the issue, but to date it has not, and sacrificing precious fastpath cycles is not attractive.
-Mike
| |