lkml.org 
[lkml]   [2013]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 02/13] misc: atmel_ssc: keep the count of pdev->id
    Hi Richard,

    On 7/1/2013 16:39, Richard Genoud wrote:
    > With device tree, pdev->id is always -1, so we introduce a local
    > counter.
    >
    > Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
    > ---
    > drivers/misc/atmel-ssc.c | 7 +++++++
    > 1 file changed, 7 insertions(+)
    >
    > diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c
    > index 3afbd82..d1ec5ab 100644
    > --- a/drivers/misc/atmel-ssc.c
    > +++ b/drivers/misc/atmel-ssc.c
    > @@ -173,6 +173,12 @@ out:
    > return err;
    > }
    >
    > +/* counter of ssc devive instances.
    > + * With device tree pdev->id is always -1, so we have to keep the
    > + * count ourselves
    > + */
    > +static int ssc_device_id;

    Do we really need this? If Yes, would it better to get from device
    through of_alias_get_id?

    > +
    > static int ssc_probe(struct platform_device *pdev)
    > {
    > struct resource *regs;
    > @@ -235,6 +241,7 @@ static int ssc_probe(struct platform_device *pdev)
    > }
    >
    > spin_lock(&user_lock);
    > + pdev->id = ssc_device_id++;
    > list_add_tail(&ssc->list, &ssc_list);
    > spin_unlock(&user_lock);
    >
    >

    Best Regards,
    Bo Shen



    \
     
     \ /
      Last update: 2013-07-02 05:41    [W:4.038 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site