Messages in this thread | | | Subject | Re: [RFC Patch net-next 2/5] net: introduce generic inet_pton() | From | Cong Wang <> | Date | Mon, 01 Jul 2013 15:05:15 +0800 |
| |
On Thu, 2013-06-27 at 14:51 -0700, Stephen Hemminger wrote: > > > > +static inline int inet_pton(const char *str, union inet_addr *addr) > > +{ > > > > A couple of comments: > 1. No reason for this to be inline
Okay, I will move them into net/core/utils.c.
> 2. If function has same name as userspace it must have same arguments > and return value. Either: > a. rename it to kinet_pton or some other name > b. make it work the same. >
Makes sense too me, I will try your option b) first, if it is over-kill I will fall back to option a).
Thanks!
| |