lkml.org 
[lkml]   [2013]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] mce: acpi/apei: Add a boot option to disable ff mode for corrected errors
On 06/28/2013 11:01 PM, Tony Luck wrote:
>> + if (sec_sev == GHES_SEV_CORRECTED &&
>> + (gdata->flags & CPER_SEC_ERROR_THRESHOLD_EXCEEDED) &&
>> + (mem_err->validation_bits & CPER_MEM_VALID_PHYSICAL_ADDRESS)) {
>> + unsigned long pfn;
>> + pfn = mem_err->physical_addr >> PAGE_SHIFT;
>
> As Reagan said "Trust ... but verify" ... we should make sure BIOS
> gave us a good pfn
> if (pfn_valid(pfn))
> soft_memory_failure_queue(pfn, 0, 0);
> else
> printk( ...something about
> BIOS giving us bad pfn = %lu\n", pfn);

Ah, nice catch - I thought soft_offline_page() takes care of this, but
it sure is good to point a finger at the firmware.

Thanks!
- Naveen

>> + }
>



\
 
 \ /
  Last update: 2013-07-01 17:41    [W:0.266 / U:0.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site