Messages in this thread | | | Subject | Re: [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr | From | Cong Wang <> | Date | Mon, 01 Jul 2013 16:40:49 +0800 |
| |
On Thu, 2013-06-27 at 01:01 -0700, Eric Dumazet wrote: > On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote: > > struct inet_peer { > > /* group together avl_left,avl_right,v4daddr to speedup lookups */ > > struct inet_peer __rcu *avl_left, *avl_right; > > - struct inetpeer_addr daddr; > > + union inet_addr daddr; > > Please compare sizeof(struct inetpeer_addr) and sizeof(union inet_addr) > > If I am not mistaken, its 20 bytes instead of 28 > > Yes, sockaddr_in6 is a bit bloated... >
You are right.
Are you saying that I should rearrange the fields of struct inet_peer in case of cacheline miss?
Thanks!
| |