lkml.org 
[lkml]   [2013]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC Patch net-next 3/5] inetpeer: use generic union inet_addr
From
Date
On Thu, 2013-06-27 at 01:01 -0700, Eric Dumazet wrote:
> On Thu, 2013-06-27 at 14:43 +0800, Cong Wang wrote:
> > struct inet_peer {
> > /* group together avl_left,avl_right,v4daddr to speedup lookups */
> > struct inet_peer __rcu *avl_left, *avl_right;
> > - struct inetpeer_addr daddr;
> > + union inet_addr daddr;
>
> Please compare sizeof(struct inetpeer_addr) and sizeof(union inet_addr)
>
> If I am not mistaken, its 20 bytes instead of 28
>
> Yes, sockaddr_in6 is a bit bloated...
>

You are right.

Are you saying that I should rearrange the fields of struct inet_peer in
case of cacheline miss?

Thanks!



\
 
 \ /
  Last update: 2013-07-01 12:21    [W:0.032 / U:0.572 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site